Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wayland hotkeys #1093

Merged

Conversation

Etaash-mathamsetty
Copy link
Contributor

@Etaash-mathamsetty Etaash-mathamsetty commented Aug 17, 2023

ready for review!

src/keybinds.cpp Outdated Show resolved Hide resolved
src/wayland_hook.h Outdated Show resolved Hide resolved
@Etaash-mathamsetty
Copy link
Contributor Author

Etaash-mathamsetty commented Aug 22, 2023

hooking up vulkan will require us to use elf and replace every instance of wl_display_flush, im not interesting in doing that :/
there's got to be a way of setting LD_PRELOAD in a vulkan layer

@jansol
Copy link
Contributor

jansol commented Sep 14, 2023

Maybe have a look at what renderdoc's capture layer does? It also registers a hotkey that bypasses the app where the layer is loaded.

@i509VCB
Copy link

i509VCB commented Sep 15, 2023

Maybe have a look at what renderdoc's capture layer does? It also registers a hotkey that bypasses the app where the layer is loaded.

This would require intercepting messages. Maybe something using libei could work? Although that would still require compositor support

@Etaash-mathamsetty
Copy link
Contributor Author

libei

does plasma 5.27 support libei?

@Etaash-mathamsetty Etaash-mathamsetty marked this pull request as ready for review November 12, 2023 05:04
@Etaash-mathamsetty
Copy link
Contributor Author

Etaash-mathamsetty commented Nov 12, 2023

hooking up vulkan will require us to use elf and replace every instance of wl_display_flush, im not interesting in doing that :/ there's got to be a way of setting LD_PRELOAD in a vulkan layer

im a stupid guy in a world that has already done this before in a more sane and nice way :)
(overloading CreateWaylandSurfaceKHR in the layer)

@Etaash-mathamsetty
Copy link
Contributor Author

Etaash-mathamsetty commented Nov 12, 2023

missing things:
1. support for multiple wl displays (not needed)
2. ifdefs for wayland (done)
3. shifting some of the wayland keyboard stuff out of keybinds.cpp

no more missing things ?

@Etaash-mathamsetty Etaash-mathamsetty changed the title Implement wayland keylogger Implement wayland hotkeys Feb 18, 2024
@flightlessmango
Copy link
Owner

Can you squash the unnecessary commits?

@Etaash-mathamsetty
Copy link
Contributor Author

Can you squash the unnecessary commits?

yea should I squash all of them into one or?

@flightlessmango
Copy link
Owner

yea should I squash all of them into one or?

Yeah I think that would be fine

@flightlessmango flightlessmango merged commit c058a38 into flightlessmango:master Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants