Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCOL-2039: Preprocess message before batch consumption #206

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

lionelpereira
Copy link
Collaborator

Pull Request Template

Description

  1. Allow messages to be pre_processed prior to consumption in pre_process method

Use case: Adding a store_id value in bulk, instead of individually when building record

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor nit pick - also please add a line to the CHANGELOG!

@@ -169,9 +169,17 @@ def upsert_records(messages)
updater.mass_update(record_list)
end

# Process messages prior to saving to datbase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, "database"

@dorner
Copy link
Member

dorner commented Dec 1, 2023

Looks good, thanks!

@dorner dorner merged commit 58e12d2 into master Dec 1, 2023
5 checks passed
@dorner dorner deleted the CCOL-2039-preprocess branch December 1, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants