Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functionality to remove ads from the freeagency page #10

Closed
wants to merge 1 commit into from

Conversation

LaCodeA
Copy link

@LaCodeA LaCodeA commented Dec 4, 2014

With the added columns on the 'freeagency' page, the ads block off some of the columns. This addition removes the ads from the page.

@flipperbw
Copy link
Owner

My only issue with doing it this way is that ESPN might complain about it. Adblock prevents the calls from ever being made, whereas this method will still force the advertiser to pay for what would essentially be impression fraud. :(

I need to find a different way to smush them to the sides so they don't overlap. It shouldn't be too hard to do that, I just haven't messed with the css yet.

@LaCodeA
Copy link
Author

LaCodeA commented Dec 4, 2014

I thought about that as well. I will work on moving them to the sides,
thanks for the fast response. Also, thanks so much for creating this
amazing plugin, found it on reddit, you are a hero my friend! I will also
look at the other feature requests that you are looking into and do my best
to contribute as much as I can.

-Lakota

On Wed, Dec 3, 2014 at 7:29 PM, flipperbw notifications@github.com wrote:

My only issue with doing it this way is that ESPN might complain about it.
Adblock prevents the calls from ever being made, whereas this method will
still force the advertiser to pay for what would essentially be impression
fraud. :(

I need to find a different way to smush them to the sides so they don't
overlap. It shouldn't be too hard to do that, I just haven't messed with
the css yet.


Reply to this email directly or view it on GitHub
#10 (comment).

@flipperbw
Copy link
Owner

Okay, I got it. Check the recent commit and let me know if that works.

@flipperbw flipperbw closed this Dec 4, 2014
@flipperbw
Copy link
Owner

And thanks for the help! Always appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants