Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature and Gate Tweaks #45

Merged
merged 21 commits into from Apr 4, 2015
Merged

Feature and Gate Tweaks #45

merged 21 commits into from Apr 4, 2015

Commits on Apr 3, 2015

  1. Move feature name to parameter on open? from Gate#initialize 

    No need for feature name everywhere in gate. This feels like a step in right 
direction. Still more tweaks to come.
    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    bd6c479 View commit details
    Browse the repository at this point in the history

  2. Move gate instrumentation to feature 

    Only gate open? is instrumented and having it in gate requires passing it to 
gate from feature.
    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    929da17 View commit details
    Browse the repository at this point in the history

  3. Use gate value typecasting instead of just to_i for open? check in pe… 

    …rcentage

gates
    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    eaf1a86 View commit details
    Browse the repository at this point in the history

  4. Move typecasting to Typecast module from GateValues

    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    161f635 View commit details
    Browse the repository at this point in the history

  5. Alias Feature#groups as #enabled_groups

    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    295ed56 View commit details
    Browse the repository at this point in the history

  6. Flipper group and group_names should be Set like everything else

    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    9309a00 View commit details
    Browse the repository at this point in the history

  7. Add Feature#disabled_groups

    @jnunemaker
    jnunemaker committed Apr 3, 2015
    1 Configuration menu
    Copy the full SHA
    e63c51d View commit details
    Browse the repository at this point in the history

  8. Make enabled_groups the method and alias groups to be consistent with 

    disabled_groups
    @jnunemaker
    jnunemaker committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    5b634a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2015

  1. Merge branch 'master' into gate-tweaks 

    Conflicts:
	lib/flipper/feature.rb
	lib/flipper/gate_values.rb
	spec/flipper/gates/percentage_of_time_spec.rb
    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    06328e0 View commit details
    Browse the repository at this point in the history

  2. Stop passing instrumenter to gate 

    No longer used.
    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    0dadd50 View commit details
    Browse the repository at this point in the history

  3. Check gate instance type instead of using gates

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    21876ba View commit details
    Browse the repository at this point in the history

  4. Denote features as public

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    c205f6a View commit details
    Browse the repository at this point in the history

  5. Denote key as public

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    d40e4ee View commit details
    Browse the repository at this point in the history

  6. Remove memoization from to_s and to_param 

    Seems like it could be dangerous if anything that used these modified
them in place
    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    02f4257 View commit details
    Browse the repository at this point in the history

  7. Update docs for feature

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    052dbe5 View commit details
    Browse the repository at this point in the history

  8. Remove gate enable/disable 

    No longer used
    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    c34ea39 View commit details
    Browse the repository at this point in the history

  9. Add name, key and data type to gate inspect

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    a98742d View commit details
    Browse the repository at this point in the history

  10. Remove source from specs 

    Not needed. Can always add back if we need to check the source of the
memory adapter.
    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    a2e45a9 View commit details
    Browse the repository at this point in the history

  11. Update spec/docs for integration spec

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    482deff View commit details
    Browse the repository at this point in the history

  12. Ensure that GateValues#[] returns nil for bad ivar

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    fc975f7 View commit details
    Browse the repository at this point in the history

  13. Document legit ivars constant

    @jnunemaker
    jnunemaker committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    c6a3211 View commit details
    Browse the repository at this point in the history