New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature and Gate Tweaks #45
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bd6c479
Move feature name to parameter on open? from Gate#initialize
jnunemaker 929da17
Move gate instrumentation to feature
jnunemaker eaf1a86
Use gate value typecasting instead of just to_i for open? check in pe…
jnunemaker 161f635
Move typecasting to Typecast module from GateValues
jnunemaker 295ed56
Alias Feature#groups as #enabled_groups
jnunemaker 9309a00
Flipper group and group_names should be Set like everything else
jnunemaker e63c51d
Add Feature#disabled_groups
jnunemaker 5b634a4
Make enabled_groups the method and alias groups to be consistent with
jnunemaker 06328e0
Merge branch 'master' into gate-tweaks
jnunemaker 0dadd50
Stop passing instrumenter to gate
jnunemaker 21876ba
Check gate instance type instead of using gates
jnunemaker c205f6a
Denote features as public
jnunemaker d40e4ee
Denote key as public
jnunemaker 02f4257
Remove memoization from to_s and to_param
jnunemaker 052dbe5
Update docs for feature
jnunemaker c34ea39
Remove gate enable/disable
jnunemaker a98742d
Add name, key and data type to gate inspect
jnunemaker a2e45a9
Remove source from specs
jnunemaker 482deff
Update spec/docs for integration spec
jnunemaker fc975f7
Ensure that GateValues#[] returns nil for bad ivar
jnunemaker c6a3211
Document legit ivars constant
jnunemaker File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍