Remove redundant deletion of feature gate in Flipper::Adapters::ActiveRecord#set. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiet
commented
Apr 18, 2024
| @@ -3,7 +3,7 @@ module Flipper | |||
| # | |||
| # adapter = Flipper::AdapterBuilder.new do | |||
| # use Flipper::Adapters::Strict | |||
| # use Flipper::Adapters::Memoizer | |||
| # use Flipper::Adapters::Memoizable | |||
There was a problem hiding this comment.
This is unrelated to the PR but I thought I added this small typo fix. I'm happy to create another PR for this if that's more appropriate.
khiet
commented
Apr 18, 2024
| @@ -221,7 +221,6 @@ def set(feature, gate, thing, options = {}) | |||
| @gate_class.transaction do | |||
| clear(feature) if clear_feature | |||
| delete(feature, gate) | |||
| @gate_class.where(feature_key: feature.key, key: gate.key).destroy_all | |||
There was a problem hiding this comment.
The above delete does the same destroy_all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed the duplicate deletions in
Flipper::Adapters::ActiveRecord#setThe
Flipper::Adapters::ActiveRecord#deletealready does the samedestroy_all.