Add linting/codestyle control

[glitchcore]

Nobody want to work with dirty code and I suggest:

• Automatic formatting code tool that allow check C/C++ and Rust code style or make formatting by one command
• CI pipeline to prevent merge of pull requests if the style check was not successful

Also need to add information about code style checking to contribution guide.

I hear about clang format

[glitchcore]

(from #39) At this time I prefer default rustfmt settings as code style (https://rust-lang.github.io/rustfmt/?version=master&search=) even in C/C++ code (where applicable, of course)

I suggest adapt rustfmt defaults to clang format

[glitchcore]

@officialdarksheao can I assign you to this task?

[glitchcore]

We have a lot of thirdparty SDK code in target_f* folders now, I don't like its style and maybe we should ignore it

[glitchcore]

@nikita-b can I assign you to this task?

[nikita-b]

@glitchcore Yes, sure

[glitchcore]

@nikita-b Do you still want to do this task?

[pavel-demin]

CI pipeline to prevent merge of pull requests if the style check was not successful

Here's an example of an action that executes clang-format on each push. If the code changes after formatting, this action creates an additional commit with a fixed commit message ("apply clang-format").

What do you think about this approach?

[nikita-b]

@glitchcore Yes, sorry for the delay. I'll start today.

[reendael]

CI pipeline to prevent merge of pull requests if the style check was not successful

Here's an example of an action that executes clang-format on each push. If the code changes after formatting, this action creates an additional commit with a fixed commit message ("apply clang-format").

What do you think about this approach?

Wouldn't it be better if a pre-commit hook ran clang-format check, detected if the output differed from the input file and notified the developer with a warning and a hint to run clang-format manually?

This way developers are encouraged to periodically (or automatically) run clang-format themselves and even more importantly, will prevent pollution of git history with formatting commits.

[pavel-demin]

Wouldn't it be better if a pre-commit hook ran clang-format check, detected if the output differed from the input file and notified the developer with a warning and a hint to run clang-format manually?

Since the pre-commit hooks run locally on the developer's machine, and the clang-format parameters change from version to version, we'll need to make sure that all developers have the same clang-format version.

[pavel-demin]

Formatting errors can be detected with the following command:

clang-format --dry-run --Werror --ferror-limit=1 <file>

[nikita-b]

CI pipeline to prevent merge of pull requests if the style check was not successful

Here's an example of an action that executes clang-format on each push. If the code changes after formatting, this action creates an additional commit with a fixed commit message ("apply clang-format").
What do you think about this approach?

Wouldn't it be better if a pre-commit hook ran clang-format check, detected if the output differed from the input file and notified the developer with a warning and a hint to run clang-format manually?

This way developers are encouraged to periodically (or automatically) run clang-format themselves and even more importantly, will prevent pollution of git history with formatting commits.

Pre-commit hook is a great idea, but I think it'll be more complicated for contributors with the Windows machine and new contributors. I suggest starting with CI and git history won't be a problem if we squash commits before a merge.