fix(cmd/grpc): skip eval data service when evaluation API auth excluded #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George MacRorie <me@georgemac.com>
GeorgeMac
force-pushed
the
gm/fix-eval-auth-exclude
branch
from
0bdbcbc
to
6797612
Compare
markphelps
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks @GeorgeMac ! Would you mind cherry picking onto the 1.40.1 branch as well for a bug fix release?
GeorgeMac
added a commit
that referenced
this pull request
Apr 23, 2024
…ed (#3018) Signed-off-by: George MacRorie <me@georgemac.com>
GeorgeMac
added a commit
that referenced
this pull request
Apr 23, 2024
…ed (#3018) Signed-off-by: George MacRorie <me@georgemac.com>
GeorgeMac
added a commit
that referenced
this pull request
Apr 23, 2024
…ed (#3018) Signed-off-by: George MacRorie <me@georgemac.com>
markphelps
pushed a commit
that referenced
this pull request
Apr 24, 2024
…ed (#3018) Signed-off-by: George MacRorie <me@georgemac.com> Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
markphelps
added a commit
that referenced
this pull request
Apr 24, 2024
* 'main' of https://github.com/flipt-io/flipt: chore(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 in /sdk/go (#3006) chore(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 in /core (#3005) chore: update changelog for v1.40.2 (#3020) refactor(storage): move from lib/pq to pgx (#2996) fix(cmd/grpc): skip eval data service when evaluation API auth excluded (#3018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3017
This skips authentication for the evaluation data service when the evaluation API is marked as skipping authentication.