feat: add support for ghe #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
approved these changes
May 30, 2024
There was a problem hiding this comment.
Looks great to me! Thank you @tvcsantos !
Would you mind signing the DCO so we can merge?
|
@all-contributors please add @tvcsantos for code |
|
I've put up a pull request to add @tvcsantos! 🎉 |
how can i do it? |
@tvcsantos if you do a rebase with |
Signed-off-by: Tiago Santos <tvcsantos@gmail.com>
Signed-off-by: Tiago Santos <tvcsantos@gmail.com>
auto-merge was automatically disabled
May 30, 2024 12:39
Head branch was pushed to by a user without write access
tvcsantos
force-pushed
the
feature/add-ghe-support
branch
from
6ffbe23
to
35a6002
Compare
done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for GHE (Self hosted GitHub Enterprise).
Currently only github.com is supported. In some cases there is the need to have GitHub running on a self hosted instance due to security and isolation reasons. This PR adds support for all GitHub scenarios.
Note: Separate PR from #3127