-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add error for dot syntax in record selection #7930
Conversation
Hmm it seems the
In summary, the first option silently allows the old record syntax and then we fix things in the background and finally disallow it, or we do everything in one pr. |
Lets do it incrementally. |
@magnus-madsen compiler works now. We "just" have breaking changes in the community build. |
Somehow, the EDIT: When I try this in VSCode everything works, i.e., compilation of a program with |
Uh. Hmm. It should not if you return a soft failure. |
Where do you see it crashing? I don't see it. |
Could you split this PR into two: one with all the fixes to the syntax and one with the actual error. (because the latter PR is kind of blocked until community builds are updated). |
What's the "status" on this? |
This is done. Only fails because of the community build where libraries still use the dot notation for records |
Updates the weeder with a helpful error message when using dot syntax with record selection.
Related to #7916
Related to #7897