Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util to generate large test flix programs for example lattices. #169

Merged
merged 3 commits into from
Jun 8, 2016

Conversation

luqmana
Copy link
Contributor

@luqmana luqmana commented Jun 8, 2016

No description provided.


def main(args: Array[String]): Unit = {

val lattices = HashMap(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally use Map(...) instead of specifying some concrete implementation (like HashMap(...)).

@mhyee
Copy link
Member

mhyee commented Jun 8, 2016

I had some very minor comments. You can merge it in once they're resolved. Other than that, looks good!

@mhyee
Copy link
Member

mhyee commented Jun 8, 2016

Actually, I just remembered. Since you're contributing code and we're open-sourcing Very Soon (TM), please add yourself to the contributors document (sorted alphabetically by last name). It shows that 1) you contributed something, and 2) you agree that your contributions are open-sourced under the Apache 2.0 license.

You should also add a copyright header to that file, since you own it, see RandomGraph. Just copy it and put your own name in.

@luqmana luqmana merged commit e7603a3 into master Jun 8, 2016
@magnus-madsen magnus-madsen deleted the benchmarking branch June 9, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants