feat: add Flix non-primitives and Java objects subtyping with Null type
#7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlutze
reviewed
Jun 21, 2024
main/src/ca/uwaterloo/flix/language/phase/typer/TypeReduction.scala
Outdated
Show resolved
Hide resolved
mlutze
reviewed
Jun 22, 2024
main/src/ca/uwaterloo/flix/language/phase/typer/TypeReduction.scala
Outdated
Show resolved
Hide resolved
|
What's the status on this? |
|
I am waiting for @mlutze's review. |
Please add those tests then. Thanks! |
mlutze
approved these changes
Jun 26, 2024
Be sure to hit the "ready for review" button when it's ready. Otherwise I think you're still working on it :) |
|
@chanattan Add tests and then we can go. |
mlutze
reviewed
Jun 27, 2024
| @@ -178,6 +178,7 @@ object BackendType { | |||
| case MonoType.String => BackendObjType.String.toTpe | |||
| case MonoType.Regex => BackendObjType.Regex.toTpe | |||
| case MonoType.Region => BackendObjType.Region.toTpe | |||
| case MonoType.Null => BackendObjType.Native(JvmName.ofClass(classOf[Object])).toTpe // to check | |||
There was a problem hiding this comment.
@JonathanStarup can you verify the JVM stuff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes back work from #7919.