perf(markOthers): ignore script tags (#2913)

floating-ui · May 19, 2024 · a50b33d · a50b33d
1 parent 197f1fd
commit a50b33d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/strong-ligers-look.md b/.changeset/strong-ligers-look.md
@@ -0,0 +1,5 @@
+---
+"@floating-ui/react": patch
+---
+
+perf(markOthers): avoid applying attributes to `script` tags needlessly
diff --git a/packages/react/src/utils/markOthers.ts b/packages/react/src/utils/markOthers.ts
@@ -1,6 +1,7 @@
 // Modified to add conditional `aria-hidden` support:
 // https://github.com/theKashey/aria-hidden/blob/9220c8f4a4fd35f63bee5510a9f41a37264382d4/src/index.ts
 import {getDocument} from '@floating-ui/react/utils';
+import {getNodeName} from '@floating-ui/utils/dom';
 
 type Undo = () => void;
 
@@ -69,7 +70,9 @@ function applyAttributeToOthers(
       return;
     }
 
-    Array.prototype.forEach.call(parent.children, (node: Element) => {
+    [].forEach.call(parent.children, (node: Element) => {
+      if (getNodeName(node) === 'script') return;
+
       if (elementsToKeep.has(node)) {
         deep(node);
       } else {