Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute styles object for arrow in computeStyles #347

Closed
giladgray opened this issue Jul 11, 2017 · 2 comments · Fixed by #370
Closed

compute styles object for arrow in computeStyles #347

giladgray opened this issue Jul 11, 2017 · 2 comments · Fixed by #370
Assignees
@FezVrasta
Labels
feature This would be nice to have. PRIORITY: low TARGETS: modifier Related to a modifier.

Comments

@giladgray
Copy link

per floating-ui/react-popper#34 (comment), it would seem that a data.styles.arrow object would be helpful to provide a consistent rendering experience.

currently, data.styles contains CSS properties for the popper element, and there is no equivalent for pre-computed CSS properties for the arrow.
@giladgray
Copy link
Author

@FezVrasta filed this to follow up on our discussion linked above, feel free to update it as you see fit!

@giladgray giladgray mentioned this issue Jul 11, 2017
Merged
@FezVrasta FezVrasta added feature This would be nice to have. DIFFICULTY: low PRIORITY: low TARGETS: modifier Related to a modifier. labels Jul 11, 2017
@FezVrasta
Copy link
Member

FezVrasta commented Jul 11, 2017 •
edited

I think we can add an arrowStyles property to the data object and use it in the applyStyle modifier. This shouldn't introduce any breaking change.

FezVrasta pushed a commit that referenced this issue Jul 30, 2017
feat(popper): Add data.arrowStyles property
783f5e0 
fixes #347
@FezVrasta FezVrasta mentioned this issue Jul 30, 2017
Merged
@FezVrasta FezVrasta self-assigned this Jul 30, 2017
FezVrasta added a commit that referenced this issue Aug 15, 2017
@FezVrasta
feat(popper): Add data.arrowStyles property (#370)
46ad423 
fixes #347
FezVrasta added a commit that referenced this issue Aug 15, 2017
@FezVrasta
feat(popper): Add data.arrowStyles property (#370)
9aa2150 
fixes #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FezVrasta FezVrasta

Labels
feature This would be nice to have. PRIORITY: low TARGETS: modifier Related to a modifier.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(popper): Add data.arrowStyles property floating-ui/floating-ui
2 participants
@giladgray @FezVrasta