-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support top & left arrow offsets together #37
Conversation
} else { | ||
return { left: +left } | ||
} | ||
return { top: +top, left: +left } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 @FezVrasta should I include bottom and right here too? feels like a yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, not necessary
I'm not at pc but I thought the computeStyle modifier created an object with any needed style prop just like it happens for the popper element. This way you don't need to manually specify any |
@FezVrasta |
My lib needs some refactor/cleaup so bad.. 🙄 |
ok @souporserious i think this PR is sufficient for now. |
@souporserious what's the path to merging this and #40? i'll need a release containing both of them to unblock some of my other feature work. happy to help however I can! |
Sorry been super busy this last week. Looking at everything now :) thanks for all of your work! I appreciate it. |
fixes #34