Skip to content

Commit

Permalink
Re-introduced the possibility to set disable autoShow for banner views.
Browse files Browse the repository at this point in the history
Probably by accident, the check for autoShow had been removed by
@floatinghotpot on July 31, 2016 [1]. This lead to a short flickering
(up to some seconds depending on the speed of the device and the
Internet connection) for empty ad codes (e.g., due to frequency capping)
before the library recognized that the ad code was currently unfilled.

The behaviour of the plugin should now again be as before:
- By default, the Java code sets autoShow to true
- Setting autoShow explicitly to false in JavaScript should be reflected
again now


[1]
https://github.com/aimpulse/cordova-plugin-admob/commit/f38a9cf559b1941255e75d68b33543223e748922#diff-89df21a171ffd69d7750e57d0490022f
  • Loading branch information
arneschuldt committed Oct 28, 2016
1 parent 628bc7f commit c3c6ca9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/android/AdMob.java
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,9 @@ public void run() {
bannerVisible = false;
adView.loadAd( buildAdRequest() );

//if(autoShowBanner) {
if(autoShowBanner) {
executeShowAd(true, null);
//}
}
Log.w("banner", publisherId);

if(delayCallback!=null)
Expand Down

0 comments on commit c3c6ca9

Please sign in to comment.