New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicates on firefox #54
Comments
Hey @mobamoba |
59.01. What's odd is that it says it completed successfully (in the debug console) but then never really stops and just gives repeats of that same error and then continuously eats CPU. |
Did you create a new account? Did you select the root bookmarks folder in your browser or a sub folder? |
Yes. And unfortunately, in addition to the message I noted above, the extension also kept creating a bunch of dupes. |
Then I recommend resetting the custom folder and letting it create a new one for you, so you can see what is going on and sort it out. When using the root folder for syncing, bookmarks that have been placed in the root folder are not visible in your browser! So, when you see what's going on in a separate dedicated floccus folder, I recommend saving all bookmarks that are only in the dedicated folder to some other location and then deleting everything in the folder, so you have a clean slate. What do you mean by "it created dupes"? You had the same bookmarks in your browser and on the server and they weren't deduped? Or did it create duplicates out of the blue? |
It created dupes out of the blue then threw dupe errors. These dupes weren't present before - they were created by the extension. I'll try what you recommended but, because of the dupes, my original 700 bookmarks have now blossomed to around 2000 on my Nextcloud server and there's no easy way that I can see to bulk delete them. Do you know how to do that? Because if so, I'd be happy to delete everything on my server, set up a new sync with a new root folder, and report back what happens. I have backups of my original bookmarks so it doesn't really matter if the extension messes them up as I can always disable the extension, delete everything, and restore my originals from backup. |
Syncing your nextcloud account to a newly created folder (go to floccus options -> 'options' in your account -> Sync folder # reset) should work, then you can remove everything in there to remove everything on the server. Afterward you will need to restore your bookmarks in your browser to the way they were. |
Oh, and I need the bookmarks app version you have installed on your nextcloud. |
Any news on this? EDIT: You may want to try the latest unreleased changes to the bookmarks app, which add a bulk editing feature. |
Sorry I spaced this. I'll set it up then see how it goes over the next few days with floccus only syncing to the floccus subfolder. Thinking about it though, I wonder if the reason I wound up with all those dupes had something to do with using Floccus on Chrome as well as Firefox, like maybe Floccus thought they were different bookmarks when really they were the same set of bookmarks. ETA: Just tried it again and it never finishes syncing (and keeps eating CPU). Floccus hangs at bookmark 621 out of about 700. |
It stops during the initial sync with a new folder? Can you provide a (censored) log? Firefox
|
I let the sync run for over an hour and it never finished. Plus it was sucking up so much CPU that my browser dragged to a crawl. Here are the errors from the debug log:
|
@mobamoba If that is your real host, username and password in the logs, please change them now in nextcloud, for your own protection... |
Ugh thanks. Changed all the login info to be safe. |
So, I couldn't gather much from the logs, sadly. It may be best to remove the 2000 bookmarks from nextcloud. You should be able to do that with the new bookmarks app UI, which has not yet been released. I've attached a build of the latest changes to make it easier for you to install: Simply extract the archive over the bookmarks app directory on your nextcloud server. |
Okay but I'm not sure what else I can provide you other than the logs. What else would help debug this? |
You could check the network tab in the debug console during syncing. It should show the network traffic between floccus and nextcloud. |
The new version of Bookmarks didn't work unfortunately. |
oh. What happened? You may need to disable the app, and re-enable it. |
Yeah I did that. The Bookmarks page just had a swirling circle on it but nothing ever loaded. |
Mmmh. Ctrl+F5 / F5 ? |
I did everything - even deleted the /apps/bookmarks directory and added it back. Still didn't work. Ended up deleting the new version and reverting to the old which doesn't let me bulk delete. |
sigh ok, I'm sorry that didn't work. EDIT: You could also remove all bookmarks using SQL :D |
(In order to remove bookmarks on nextcloud using SQL you can use I've released a new version of floccus which has some fixes which might solve this issue, but hopefully also errors before creating any duplicates on its own in the future, so we I can investigate why that happens at all. |
I deleted the bookmarks. However, with the new version, absolutely nothing happens, no sync, nothing. It connects, syncs for 1 second, uploads nothing, then declares a successful sync. The only new thing in the debug log is: |
Does resetting the sync folder help? Make sure to not set it to the old folder. Otherwise it'll upload all your duplicates again... 🙈 The empty array is good as it indicates floccus has received all bookmarks from the server (there are none on there, right?). |
I can confirm it worked without wiping anything. The three errors just went away and things work normally for me. I then synced that folder to another machine with no problems. |
The only thing I notice that's different on machine 2 is that the ordering of the bookmarks (I'm using only the bookmarks toolbar folder synced) is different on the second machine than it was set on the first. |
I'll try ordering them on machine 2 and see if 1 is adjusted accordingly. |
The order is not possible to be synced, atm. |
Ah I see I set it per machine/profile thanks! |
Even after removing Floccus, restarting Firefox, and reinstalling, there's no way to add an account. Nothing comes up in the Options setting and clicking the icon brings up an empty box. |
2.0.5 - the one up on the official Firefox site. |
Does #54 (comment) work? |
Nothing works. The options page opens nothing other than the description portion. |
Then we will need to open the debugger again and have a peek at the console. ( |
``Error: Could not establish connection. Receiving end does not exist. undefined |
Mmh. All messages appear to be unrelated. Did you open the debugger first and then open / reload the options page? This ensures that errors thrown during page setup are caught in the debugger, but I doubt anything new will come up. |
I did that; that's all that came up. |
Bummer. I'm sure this must be frustrating. Can you think of anything that might be different in your setup from other setups? e.g. locale, operating system, any specific settings like private browsing by default, etc. |
Well I've progressed a little. I can now create an account and select a folder but nothing happens. Sync Now is gray and pressing it does nothing even though it says it's syncing. Run Tests came out with all green checkmarks. Here's the debug log:
The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol. background.html |
does the problem persist, if you delete the account, recreate it and then sync again? |
Well somehow the problem vanished and it now works on both Firefox and Chrome. I think Firefox was getting stuck in an account syncing loop of some kind because I noticed once I disabled account sync and restarted, I was able to work normally with Floccus. I re-enabled sync afterwards - perhaps all the bookmark changes "confused" Firefox in some with its on internal syncing mechanism or something. At any rate, it's all working thanks! |
Phew. I'm glad it works, now. 😅 Re internal syncing mechanism: Do you have Firefox sync enabled? |
Yes I do. |
Ah, please don't. Firefox Sync is known to cause problems, because it changes the IDs of your bookmarks and floccus is left out in the cold. |
Oh okay. I didn't see a notation of that anywhere so I didn't know. I'll leave Firefox Sync off for Bookmarks but on for everything else - that should be fine right? |
I think so, yep. I see, I'll try to make it more prominent in the README as well :) |
Yeah, I only looked at the Firefox Install section on the main page then at the description on the AMO site - I'd stick in all-caps in both places because Firefox Sync was, I think, definitely the source of some of the problems. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I'm using the 2.0.0. installed from AMO. In the debugging log, I get the following error over and over:
Error: Could not establish connection. Receiving end does not exist.
Chrome extension has no problem connecting to the exact same server. Also, with Firefox, clicking "Add Account" does nothing for a while after initial install - I had to click it 6 or so times after initial install in order to get the account window to finally show.
Let me know if there's anything additional that would help you debug. Thanks.
The text was updated successfully, but these errors were encountered: