Fixed memory leak and turned off disk response caching.

floehopper · Sep 6, 2007 · 7c003e3 · 7c003e3
1 parent 6748447
commit 7c003e3
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/Classes/CCMAppController.m b/Classes/CCMAppController.m
@@ -8,18 +8,31 @@
 
 @implementation CCMAppController
 
-- (void)start
+- (void)setupRequestCache
+{
+	NSURLCache *cache = [NSURLCache sharedURLCache];
+	[cache setDiskCapacity:0];
+	[cache setMemoryCapacity:2*1024*1024];
+}
+
+- (void)registerValueTransformers
 {
 	CCMBuildStatusTransformer *statusTransformer = [[[CCMBuildStatusTransformer alloc] init] autorelease];
 	[statusTransformer setImageFactory:imageFactory];
 	[NSValueTransformer setValueTransformer:statusTransformer forName:CCMBuildStatusTransformerName];
 
 	CCMTimeSinceDateTransformer *dateTransformer = [[[CCMTimeSinceDateTransformer alloc] init] autorelease];
 	[NSValueTransformer setValueTransformer:dateTransformer forName:CCMTimeSinceDateTransformerName];
-
+}
+
+- (void)startGrowlAdaptor
+{
 	CCMGrowlAdaptor *growlAdaptor = [[CCMGrowlAdaptor alloc] init]; // intentional 'leak'
 	[growlAdaptor start]; 
-
+}
+
+- (void)startServerMonitor
+{
 	monitor = [[CCMServerMonitor alloc] init];
 	[monitor setNotificationCenter:[NSNotificationCenter defaultCenter]];
 	[monitor setUserDefaults:[NSUserDefaults standardUserDefaults]];
@@ -32,7 +45,10 @@ - (void)applicationDidFinishLaunching:(NSNotification *)aNotification
 {
 	@try
 	{
-		[self start];
+		[self setupRequestCache];
+		[self registerValueTransformers];
+		[self startGrowlAdaptor];
+		[self startServerMonitor];
 	}
 	@catch(NSException *e)
 	{

diff --git a/Classes/CCMServerStatusReader.m b/Classes/CCMServerStatusReader.m
@@ -41,7 +41,7 @@ - (NSString *)fixUrlStringIfNecessary:(NSString *)urlString
 
 - (NSArray *)projectInfos
 {
-    NSXMLDocument *doc = [[NSXMLDocument alloc] initWithData:responseData options:NSXMLNodeOptionsNone error:nil];	
+    NSXMLDocument *doc = [[[NSXMLDocument alloc] initWithData:responseData options:NSXMLNodeOptionsNone error:nil] autorelease];	
 	NSMutableArray *infoArray = [NSMutableArray array];
 	NSEnumerator *projectEnum = [[doc nodesForXPath:@"//Project" error:nil] objectEnumerator];
 	NSXMLElement *element = nil;

diff --git a/Resources/Info.plist b/Resources/Info.plist
@@ -19,9 +19,9 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>0.9.3d7</string>
+	<string>0.9.3d8</string>
 	<key>CFBundleShortVersionString</key>
-	<string>0.9.3d7</string>
+	<string>0.9.3d8</string>
 	<key>LSUIElement</key>
 	<string>1</string>
 	<key>NSMainNibFile</key>