Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more 800-numbers in Austria #352

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

andresavic
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Dec 7, 2016

Coverage Status

Coverage remained the same at 98.096% when pulling 2f74f3e on YodelTalk:fix-800-austria into e0d7591 on floere:master.

@floere
Copy link
Owner

floere commented Dec 8, 2016

@mcandy007 Thanks Andre! Is there an explanation to go with this change so I have more reasons to include this? 😊 (Not trying to be complicated, just need more reasons – 1+ reasons – to change this library's behavior)

@andresavic
Copy link
Contributor Author

@floere Hello Florian.
Many companies in Austria use 6 digit 0800 numbers.
For example A1 https://www.a1.net/service-kontakt
In the linked RTR paper, the minimum length is also indicated as 9(Including the 800 prefix).
https://www.rtr.at/en/tk/E129/2312_Austrian_Numbering_Plan_2011-03-30.pdf
screen shot 2016-12-09 at 10 08 38

@floere floere merged commit 63e4b10 into floere:master Dec 9, 2016
@ream88 ream88 deleted the fix-800-austria branch December 9, 2016 09:23
@floere
Copy link
Owner

floere commented Dec 9, 2016

@mcandy007 Hi Andre! This is excellent, thank you very much for providing the needed infos 😊 Your PR is released in version 2.15.38 🚀

@andresavic
Copy link
Contributor Author

Thank you for your fast response! 👍🏻

@floere
Copy link
Owner

floere commented Dec 9, 2016

@mcandy007 Likewise! I really appreciate it 👏🏼

@ream88 ream88 restored the fix-800-austria branch December 9, 2016 11:23
@ream88 ream88 deleted the fix-800-austria branch December 9, 2016 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants