Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kirby 3.5.x not supported in v3.0.8 #66

Closed
thathoff opened this issue Jan 18, 2022 · 7 comments
Closed

Kirby 3.5.x not supported in v3.0.8 #66

thathoff opened this issue Jan 18, 2022 · 7 comments

Comments

@thathoff
Copy link

The new version does not work with Kirby 3.5.0 anymore because the F helper class has been moved from Kirby\Toolkit\F to Kirby\Filesystem\F. The solution is to pin the plugin to version 3.0.7

Maybe you can add an info to the README or even include the requirement in the composer.json.

PS: Thanks for this great plugin 🚀

@owzim
Copy link

owzim commented Jan 20, 2022

Oh no! @flokosiol please make it keep the 3.5 compatibility. We have multiple 3.5 installations and cannot update for now.

Pinning to 3.0.7 is an ok solution, but there are other fixes in 3.0.8 we would need as well.

@flokosiol
Copy link
Owner

I'm sorry @owzim – this was not intended.

I'll try to separate this. My plan is to release a 3.0.9 with the latest fixes compatible to K3.5 and a new 3.1 with all breaking changes from K3.6. This might be the best solution, right?

@flokosiol
Copy link
Owner

Sorry for the massive delay, but I was really busy the last month doing client work.

I would like to solve #65 first, bevor creating a new version 3.1 for Kirby 3.6+

@flokosiol
Copy link
Owner

Hey folks, could you please check if the latest version of the new kirby-3.5 branch works for you?

https://github.com/flokosiol/kirby-focus/tree/kirby-3.5

I reverted the GD and IM Darkroom classes to the latest Kirby 3.5 version but tried to include the latest fix of #63 as well. It was a bit confusing to be honest. 😄 If everything is fine, I would release a new Focus version 3.0.9 for Kirby 3.5 (and 3.1 for Kirby 3.6 as well).

Thanks a lot for your support! ❤️

@thathoff
Copy link
Author

Thank you. It seems to work fine!

@flokosiol
Copy link
Owner

Great, thanks for the quick reply.

@flokosiol
Copy link
Owner

I just released 3.0.9 and hope I configured the version numbers and dependencies correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants