Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Mouse Support #46

Merged
merged 11 commits into from
Jun 21, 2019
Merged

Adds Mouse Support #46

merged 11 commits into from
Jun 21, 2019

Conversation

ivanvanderbyl
Copy link
Contributor

@ivanvanderbyl ivanvanderbyl commented Jun 18, 2019

Implements #45

Usage

// perform a click at 100 by 120 pixels from top left corner
await browser.mouse.click(100, 120)

// Perform a drag from 100,100 to 200,200
await browser.mouse.drag(
  [100, 100],
  [200, 200],
)

// primitive mouse down
await browser.mouse.down()

// primitive mouse move
await browser.mouse.move([x1,y2], [x2,y2],[xn,yn])

// primitive mouse up
await browser.mouse.up()

Supports most of the same options as Puppeteer.

Other things to note:

  • Upgrades Puppeteer to 1.17

TODO:

  • Docs
  • Tests - needs a page to test actual events.

@ivanvanderbyl ivanvanderbyl added this to the v1.1 milestone Jun 19, 2019
@ivanvanderbyl ivanvanderbyl added the enhancement New feature or request label Jun 19, 2019
@ivanvanderbyl ivanvanderbyl self-assigned this Jun 19, 2019
@ivanvanderbyl ivanvanderbyl added enhancement New feature or request and removed enhancement New feature or request labels Jun 20, 2019
Copy link
Contributor

@lachie lachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐑🍴

@ivanvanderbyl ivanvanderbyl merged commit 59e59d7 into beta Jun 21, 2019
@ivanvanderbyl ivanvanderbyl deleted the feature/mouse branch June 21, 2019 14:43
@ivanvanderbyl ivanvanderbyl mentioned this pull request Jun 21, 2019
@ivanvanderbyl ivanvanderbyl added the docs Documentation needs fixing label Mar 28, 2020
@wilsonmar
Copy link
Contributor

wilsonmar commented Mar 24, 2021

@ivanvanderbyl if this has been created, we should update https://wilsonmar.github.io/flood-the-internet/#challenges-on-the-internet-app, which has a page to test actual events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation needs fixing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants