pyloxi: parse unknown subclasses as the superclass #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would throw an exception if we encountered a (for example) experimenter action subclass that we didn't know existed. This was fine for OFTest but causes problems for other tools that use pyloxi. This change generates a full set of pack/unpack/pretty_print functions for virtual classes. If a discriminator field contains a subtype we don't know about, the virtual class is instantiated instead. This also removes the special cases around unknown hello elements.
| @@ -60,18 +60,6 @@ def test_version(self): | |||
| self.assertTrue(hasattr(loxi.of13, "message")) | |||
| self.assertTrue(hasattr(loxi.of13, "oxm")) | |||
|
|
|||
| class TestCommon(unittest.TestCase): | |||
There was a problem hiding this comment.
Should maybe have a test_data case that validates handling of unknown hello_elems (though it would probably break Java at this point)
|
LGTM (btw it would be really neat if we had a 'pull request builder' that would publish the artifacts of a PR somewhere were they can easily be inspected.) We could probably put that into Jenkins... ACK |
|
ABAT: START_MERGE: Log file at http://sbs2/abat/2014.01.29.0258-m.loxigen.master/abat.log |
bsn-abat
pushed a commit
to floodlight/loxigen-artifacts
that referenced
this pull request
Jan 29, 2014
Loxigen Head commit floodlight/loxigen@074f709 commit 074f7096e8fd4e7a63d2b9cbba68e60be9a87f31 Merge: f8498dd 038c9e6 Author: abat <abat@bigswitch.com> Date: Tue Jan 28 18:58:32 2014 -0800 Merge into master from pull request #186: pyloxi: parse unknown subclasses as the superclass (floodlight/loxigen#186) commit 038c9e6106e8756c1cd152bbbdc2ee75ffba7689 Author: Rich Lane <rlane@bigswitch.com> Date: Mon Jan 27 15:33:18 2014 -0800 pyloxi: parse unknown subclasses as the superclass Previously we would throw an exception if we encountered a (for example) experimenter action subclass that we didn't know existed. This was fine for OFTest but causes problems for other tools that use pyloxi. This change generates a full set of pack/unpack/pretty_print functions for virtual classes. If a discriminator field contains a subtype we don't know about, the virtual class is instantiated instead. This also removes the special cases around unknown hello elements.
bsn-abat
pushed a commit
that referenced
this pull request
Jan 29, 2014
pyloxi: parse unknown subclasses as the superclass (#186)
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @andi-bigswitch
Previously we would throw an exception if we encountered a (for example)
experimenter action subclass that we didn't know existed. This was fine for
OFTest but causes problems for other tools that use pyloxi.
This change generates a full set of pack/unpack/pretty_print functions for
virtual classes. If a discriminator field contains a subtype we don't know
about, the "virtual" class is instantiated instead.
This also removes the special cases around unknown hello elements.