Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few improvements to java_gen from the plane... #43

Merged
merged 5 commits into from
Aug 13, 2013

Conversation

andi-bigswitch
Copy link
Contributor

Reviewer: @rlane @yotamhc

Here's another pull request with a set of improvements I put together yesterday on the plane. It includes

  • unit tests for the discriminator parser feature + and struct/enum params
  • a check-java and a package-java target for the make file
  • various documentation enhancements
  • blacklisting of various useless types from the input (of_uint32)
  • and an experimental change to upcast the java representation of values to the next bigger type (e.g., byte -> short) to preserve the correct unsigned values. This representation has a few trade-offs of its own (e.g., it's not obvious from the type that a 'short' value that's really a uint8 will only accept values 0-255.

I won't be checking emails often during next week. Feel free to merge the changes if they look ok, or, Yotam if you'd like make changes and push a PR with the changes (or otherwise I'll do it next week).

Have a good time
-A.

@rlane
Copy link
Contributor

rlane commented Aug 5, 2013

The unit tests look fine to me. I'll let Yotam review the rest and merge this.

@yotamhc
Copy link
Contributor

yotamhc commented Aug 13, 2013

ACK

@bsn-abat
Copy link

ABAT: START_MERGE: Log file at http://vbs21/abat/2013.08.13.2349-m.loxigen.master/abat.log

bsn-abat pushed a commit that referenced this pull request Aug 13, 2013
A few improvements to java_gen from the plane... (#43)
@bsn-abat bsn-abat merged commit 2bf357c into floodlight:master Aug 13, 2013
@bsn-abat
Copy link

ABAT: ACCEPT: Successfully merged

In case you want to see the build log, check out :
Log file at http://vbs21/abat/2013.08.13.2349-m.loxigen.master/abat.log
/cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants