Allow for "* 0-24 * * *", gh-30

CREDITS.md

@@ -1,6 +1,7 @@
 
 # fugit credits
 
+* Jessica Stokes https://github.com/ticky 0-24 issue with cron, gh-30
 * Shai Coleman https://github.com/shaicoleman parse_nat enhancements, gh-24, gh-25, and gh-28
 * Jan Stevens https://github.com/JanStevens Fugit.parse('every 15 minutes') gh-22
 * Fabio Pitino https://github.com/hspazio nil on February 30 gh-21

lib/fugit/cron.rb

@@ -497,23 +497,28 @@ def range(min, max, sta, edn, sla)
 
       loop do
 
-#p({ cur: cur })
         a << cur
         break if cur == edn
 
         cur += 1
-        cur = min if cur > max
-#p cur
+        if cur > max
+          cur = min
+          edn = edn - max - 1 if edn > max
+        end
 
         fail RuntimeError.new(
           "too many loops for " +
           { min: omin, max: omax, sta: sta, edn: edn, sla: sla }.inspect +
           " #range, breaking, " +
           "please fill an issue at https://git.io/fjJC9"
-        ) if a.length > omax
+        ) if a.length > 2 * omax
+          # there is a #uniq afterwards, hence the 2* for 0-24 and friends
       end
 
-      a.each_with_index.select { |e, i| i % sla == 0 }.collect(&:first)
+      a.each_with_index
+        .select { |e, i| i % sla == 0 }
+        .collect(&:first)
+        .uniq
     end
 
     def compact(key)

spec/cron_spec.rb

@@ -47,7 +47,7 @@
     [ '0 0 * * mon#2,tue', '2017-01-09', '2017-01-06' ],
     [ '0 0 * * mon#2,tue', '2017-01-31', '2017-01-30' ],
 
-    [ '00 24 * * *', '2017-01-02', '2017-01-01 12:00' ],
+    [ '00 24 * * *', '2017-01-02 00:00:00', '2017-01-01 12:00' ],
 
     # Note: The day of a command's execution can be specified by two fields
     # -- day of month, and day of week.
@@ -692,8 +692,19 @@ class Fugit::Cron::TimeCursor
         [ '10-15 0 23 * * *', '10,11,12,13,14,15 0 23 * * *' ],
         [ '58-2 0 23 * * *', '0,1,2,58,59 0 23 * * *' ],
 
+        [ '* 0-24 * * *', "* #{(0..23).to_a.collect(&:to_s).join(',')} * * *" ],
+        [ '* 22-24 * * *', '* 0,22,23 * * *' ],
+        [ '* * * 1-13 *', nil ], # month 13 isn't allowed at parsing
+          #
+          # gh-30
+
       ].each { |c, e|
-        it("parses #{c}") { expect(Fugit::Cron.parse(c).to_cron_s).to eq(e) }
+
+        it "parses #{c}" do
+
+          c = Fugit::Cron.parse(c)
+          expect(c ? c.to_cron_s : c).to eq(e)
+        end
       }
 
       context 'negative monthdays' do
@@ -985,6 +996,12 @@ class Fugit::Cron::TimeCursor
       { min: 1, max: 31, sta: -5, edn: -1, sla: 1 } => [ -5, -4, -3, -2, -1 ],
       { min: 1, max: 31, sta: -1, edn: -29, sla: 1 } => [ -1, -31, -30, -29 ],
 
+      { min: 0, max: 23, sta: 0, edn: 24, sla: 1 } => (0..23).to_a,
+      #{ min: 1, max: 12, sta: 0, edn: 12, sla: 1 } => ...
+      #{ min: 1, max: 12, sta: 1, edn: 13, sla: 1 } => ... # month 13 no parse
+        #
+        # gh-30
+
     }.each do |args, result|
 
       it "returns #{result.inspect} for #{args.inspect}" do