-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
too many loops in #next_time/previous_time for invalid dates #21
Comments
https://crontab.guru/#*_*_31_2_* is valid, crond probably never schedules (and doesn't fail with a RuntimeError). |
jmettraux
added a commit
that referenced
this issue
May 3, 2019
jmettraux
added a commit
that referenced
this issue
May 3, 2019
Thanks! |
Thank you @jmettraux! much appreciated your quick turnaround! :) |
You're welcome :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
This is again a known issue reporting as per error message. Although the input date is incorrect (e.g. Feb 31st) the
:parse
method returns a valid object and the loop:next_time
reaches the max number of iterations.How to reproduce
Same issue occurs with all inputs that have month within 1-12 and day within 1-31 but are not valid dates:
Suggestions
parse
method returnnil
directly when invalid combination of month-day is detected?The text was updated successfully, but these errors were encountered: