This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Improved performance for batch add & update #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modification of the add(List<Object> objects) and update(List<Object> objects) functions. Instead of calling the add(Object object) which was opening and closing the database on each object, we are now opening the database and beginning the transaction once, and closing it after all the objects were inserted. I tried the change on my data set. Before It was taking me more than 1 minute to add all the data set in the database. After the modification it takes me now not more than 1 second.
|
thanks for it 👍 will send a new version |
|
Great, you're welcome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification of the add(List objects) and update(List objects) functions.
Instead of calling the add(Object object) which was opening and closing the database on each object, we are now opening the database and beginning the transaction once, and closing it after all the objects were inserted.
I tried the change on my data set. Before It was taking me more than 1 minute to add all the data set in the database. After the modification it takes me now not more than 1 second.