Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the 'core.tcp_info' command to the exporter #16

Merged

Conversation

karstenjakobsen
Copy link
Contributor

The kamcmd core.tcp_info command will also retrieve some TLS connection stats. This is useful if you need information regarding TCP and TLS connections. Example:

{
	readers: 8
	max_connections: 4096
	max_tls_connections: 4096
	opened_connections: 595
	opened_tls_connections: 595
	write_queued_bytes: 0
}

@florentchauveau
Copy link
Owner

florentchauveau commented Apr 28, 2020

Hello @karstenjakobsen!

Thank you for this. I've merged the "tls.info" before, could you rebase and resubmit?

Best

@florentchauveau
Copy link
Owner

florentchauveau commented Apr 28, 2020

Also, if core.tcp_info is available without loading a specific module, it should be safe to add it as a default collector in main.go.

What do you think?

Don't forget to update the README.md, the section about default metrics, if you think we can enable it by default :)

@karstenjakobsen
Copy link
Contributor Author

I have fixed conflicts and added core.tcp_info to main.go

collector.go Outdated Show resolved Hide resolved
Fixed conflict
@florentchauveau florentchauveau merged commit 5ddd2e0 into florentchauveau:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants