Skip to content

Commit

Permalink
explicitly clears upon exit
Browse files Browse the repository at this point in the history
this cleans up after a server has been added for a spec, since this
could otherwise leave servers hanging around
  • Loading branch information
floriank committed Sep 12, 2021
1 parent df530d2 commit 318241a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
1 change: 0 additions & 1 deletion test/mimicry_api/controllers/proxy_controller_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ defmodule MimicryApi.ProxyControllerTest do
assert [Mimicry.version()] == conn |> get_resp_header("x-mimicry-version")
end

@tag :reset_servers
test "GET / shows available hosts to pass", %{conn: conn} do
conn = conn |> get("/")
assert %{"available_hosts" => hosts} = conn |> json_response(:ok)
Expand Down
12 changes: 3 additions & 9 deletions test/support/mock_server_case.ex
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,13 @@ defmodule Mimicry.MockServerCase do

setup context do
file_name = context |> Map.get(:server, false)
reset = context |> Map.get(:reset_servers, false)

if file_name do
:ok = clear_servers()
{:ok, server_pid} = add_server(file_name)
{:ok, _server_pid} = add_server(file_name)

on_exit(fn ->
MockServerList.delete_server(server_pid)
end)
end

if reset do
:ok = clear_servers()
# make sure server is cleared afterwards
on_exit(&clear_servers/0)
end

:ok
Expand Down

0 comments on commit 318241a

Please sign in to comment.