-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 6 support #70
Comments
For the people who can't wait to move to Laravel 6, I've created a temporary fork that supports it. https://github.com/Amodar/laravel-swap. Please note the fork will be archived once this repo supports it. |
Any plans to add support soon? |
@Amodar Can you please send a pull request ? Thanks! |
Hi @florianv, First of all i want to thank you for your hard work!:) Second, from what i can gather, the issue lies in the upstream php-cache/illuminate-adapter which didn't add support for illuminate/cache 6.0; In order for him to be able to send a PR, i think this will require @Amodar to also send a PR to @php-cache/illuminate-adapter -- which sadly is readonly..so that's a bummer. What @Amodar did was also fork @php-cache/illuminate-adapter and added support for illuminate/cache 6.0. I'm looking forward to this support anyhow, as i'm building something that might put your package do some heavy lifting! |
Turns out at some point (maybe Laravel 6) the cache repository interface was updated to fully adhere to the SimpleCache contract. So you can now just pass the Laravel cache repository into the Swap Builder $builder = (new Builder)->useSimpleCache(resolve(\Illuminate\Contracts\Cache\Repository::class)); The config can then be updated to remove the cache part as this will automatically use what's set in the Laravel cache.php config / env. |
Any progress on Laravel 6 support ? EDIT: i pushed a possible alternative proposition (#73) to fix this issue. |
Any progress about Laravel 6 support? |
@kslimani Yes! |
No description provided.
The text was updated successfully, but these errors were encountered: