Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6 support #70

Closed
Amodar opened this issue Sep 4, 2019 · 10 comments
Closed

Laravel 6 support #70

Amodar opened this issue Sep 4, 2019 · 10 comments

Comments

@Amodar
Copy link

Amodar commented Sep 4, 2019

No description provided.

@Amodar
Copy link
Author

Amodar commented Sep 6, 2019

For the people who can't wait to move to Laravel 6, I've created a temporary fork that supports it. https://github.com/Amodar/laravel-swap. Please note the fork will be archived once this repo supports it.

@geodro
Copy link

geodro commented Sep 16, 2019

Any plans to add support soon?

@florianv
Copy link
Owner

@Amodar Can you please send a pull request ? Thanks!

@niladam
Copy link

niladam commented Sep 20, 2019

Hi @florianv,

First of all i want to thank you for your hard work!:)

Second, from what i can gather, the issue lies in the upstream php-cache/illuminate-adapter which didn't add support for illuminate/cache 6.0;

In order for him to be able to send a PR, i think this will require @Amodar to also send a PR to @php-cache/illuminate-adapter -- which sadly is readonly..so that's a bummer.

What @Amodar did was also fork @php-cache/illuminate-adapter and added support for illuminate/cache 6.0.

I'm looking forward to this support anyhow, as i'm building something that might put your package do some heavy lifting!

@leeovery
Copy link

Turns out at some point (maybe Laravel 6) the cache repository interface was updated to fully adhere to the SimpleCache contract.

So you can now just pass the Laravel cache repository into the Swap Builder useSimpleCache method:

$builder = (new Builder)->useSimpleCache(resolve(\Illuminate\Contracts\Cache\Repository::class));

The config can then be updated to remove the cache part as this will automatically use what's set in the Laravel cache.php config / env.

@Amodar
Copy link
Author

Amodar commented Sep 24, 2019

@florianv here it is #72. I'm not a fan of this change though as we're dependent on illuminate-adapter which is not maintained anymore.

@kslimani
Copy link
Contributor

kslimani commented Sep 30, 2019

Any progress on Laravel 6 support ?

EDIT: i pushed a possible alternative proposition (#73) to fix this issue.

@mits87
Copy link

mits87 commented Dec 29, 2019

Any progress about Laravel 6 support?

@kslimani
Copy link
Contributor

@mits87 Laravel 6 is supported since release 2.1.0.

@florianv : I think this issue should be closed ?

@florianv
Copy link
Owner

@kslimani Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants