Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6 Support #72

Closed
wants to merge 1 commit into from
Closed

Laravel 6 Support #72

wants to merge 1 commit into from

Conversation

Amodar
Copy link

@Amodar Amodar commented Sep 24, 2019

cache/illuminate-adapter does not support laravel 6 and is unfortunately set to read-only. I've forked the repo (amodar/illuminate-adapter) and adjusted the composer file to support Laravel 6.

cache/illuminate-adapter does not support laravel 6 and is unfortunately set to read-only. I've forked the repo (amodar/illuminate-adapter) and adjusted the composer file to support Laravel 6.
@Amodar Amodar mentioned this pull request Sep 24, 2019
@leeovery
Copy link

They want you to push to their main repo: https://github.com/php-cache/cache

The sub repos are read-only.

@florianv
Copy link
Owner

@Amodar Thanks a lot for your PR!
Yes, you have to submit your PR to the main PHP Cache repo
They use a script to create the sub-repos for each provider, so that's why they are read-only

@rez1dent3
Copy link

php-cache/cache#234

@rez1dent3
Copy link

@florianv The most correct solution would be to remove support for this package from your package. I support #73

@florianv
Copy link
Owner

florianv commented Oct 9, 2019

Closing in favor of #73.
Thanks !

@florianv florianv closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants