[Review Required] Drop cache adapter support with Laravel 5.8+ #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
florianv
requested changes
Oct 9, 2019
src/SwapServiceProvider.php
Outdated
| return new SimpleCacheBridge(new IlluminateCachePool($store)); | ||
| return $store instanceof \Psr\SimpleCache\CacheInterface | ||
| ? $store | ||
| : new SimpleCacheBridge(new IlluminateCachePool($store->getStore())); |
There was a problem hiding this comment.
Can you throw an exception if the class does not exist with a message suggesting to install the php-cache package ?
There was a problem hiding this comment.
I added changes in order to throw an exception if PSR-6 adapter or PSR-16 bridge is missing.
| ``` | ||
|
|
||
| These dependencies are not required with Laravel 5.8 or greater. | ||
|
|
There was a problem hiding this comment.
Can you please add the same to /doc/readme.md ?
|
Thanks a lot @kslimani |
|
Can we get a new version tagged? @florianv |
|
@josiasmontag Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer : It is a proposition only, i am not sure if it is the way to go.
Since Laravel 5.8, cache repository instance implements
\Psr\SimpleCache\CacheInterface, so (if i am not wrong) does not require simple cache bridge anymore.This PR is an attempt to drop these dependencies (by default) and also add support for Laravel 6.
For Laravel 5.7 or lesser it should simply require to add
cache/illuminate-adapterandcache/simple-cache-bridgedependencies using composer. (i edited readme file to reflect theses changes).If you disagree, simply close this PR. If it require some changes, just let me know !