Merge pull request #25 from remmel/master

Be able to set array.rates without historicalRates
florianv · Mar 11, 2019 · 0dbb22e · 0dbb22e
2 parents ce98b5b + 6f0ca95
commit 0dbb22e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -156,7 +156,6 @@ public function getConfigTreeBuilder()
                                 ->variableNode('historicalRates')
                                     ->treatFalseLike(null)
                                     ->treatTrueLike(null)
-                                    ->isRequired()
                                     ->cannotBeEmpty()
                                     ->validate()
                                         ->ifTrue(function($config) {

diff --git a/Tests/DependencyInjection/ConfigurationTest.php b/Tests/DependencyInjection/ConfigurationTest.php
@@ -140,6 +140,14 @@ public function provideValidProvidersConfigs()
                     ],
                 ],
             ]],
+            [[
+                'array' => [
+                    'rates' => [
+                        'EUR/USD' => 1.1,
+                        'EUR/GBP' => 1.5,
+                    ],
+                ],
+            ]],
         ];
     }
 
@@ -165,7 +173,6 @@ public function provideInvalidProvidersConfigs()
             [['array' => null]],
             [['array' => []]],
             [['array' => ['EUR/GBP' => 1.5]]],
-            [['array' => ['rates' => ['EUR/GBP' => 1.5]]]],
             [['array' => ['rates' => [['EUR/GBP' => 0]]]]],
             [['array' => ['rates' => [['any' => 'any']]]]],
             [['array' => ['rates' => [['2017-01-01' => 'any']]]]],