Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Windchill application specification #5

Merged
merged 6 commits into from
Mar 4, 2019

Conversation

jdmedlock
Copy link
Collaborator

Add Windchill application specification

Resolves: N/a
See also: N/a

jdmedlock and others added 4 commits March 3, 2019 15:02
Add Timezone Slackbot app idea

Resolves: N/a
See also: N/a
…o feature/add-tz-bot

Refactor: Resolve merge conflict with `master` branch
Add Windchill application specification

Resolves: N/a
See also: N/a
- [ ] User can enter the actual temperature (Celcius) and the wind speed
(kilometers per hour)
- [ ] User can press the `Calculate` button to display the wind chill
- [ ] User will receive and error message if data values are not entered
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. "error message if ... or if the resulting wind chill factor is greater..."
Is this also an error message? Shouldn't this be the actual result and not an error? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more advanced developers this would actually be an assertion since by definition, wind chill factors must be less than the actual temperature. However, since this is a beginner app I didn't want to introduce assert so I left chose to specify it as an error. It really signifies there's a problem with the calculation if this case is true.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see... Thanks for the clarification!

- [ ] User will receive and error message if data values are not entered
or if the resulting wind chill factor is greater than or equal to the
actual temperature.
- [ ] User will be prompted to enter new data values if `Calculate` is
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this in to the bonus features and the English metric to be a User story as it seems much more of a "must" to have metric system also... What do you say? 🤔

Copy link
Collaborator Author

@jdmedlock jdmedlock Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I left the basic requirement to edit for valid input as a requirement, but moved the other two to bonus features.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!


## Bonus features

- [ ] User can select the measurement system calculations will be performed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other bonus feature: User can see the wind chill factor field automatically changed when both fields have valid data or something like that -> this means that the user doesn't have to press the button always to perform the calculation. It could be done on the onChange event on the inputs,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Good idea...great way to teach event handling.

…17/app-ideas into feature/add-wind-chill

Refactor: Resolve merge conflicts with `master` branch
Implement suggestions from PR review
- See [PR comments](#5) for details

Resolves: N/a
See also: N/a
@florinpop17 florinpop17 merged commit 07f91a7 into master Mar 4, 2019
@florinpop17 florinpop17 deleted the feature/add-wind-chill branch March 4, 2019 18:55
@jdmedlock jdmedlock restored the feature/add-wind-chill branch March 4, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants