Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate hints for international phonetic alphabet #1089

Closed
Glitchy-Tozier opened this issue Jul 23, 2021 · 5 comments · Fixed by #1091
Closed

Duplicate hints for international phonetic alphabet #1089

Glitchy-Tozier opened this issue Jul 23, 2021 · 5 comments · Fixed by #1091
Labels
area: kbd-layout Keyboard layout requests / issues / improvements bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@Glitchy-Tozier
Copy link
Collaborator

Short description

The hints double, showing two circles instead of one. See sreenshots

Steps to reproduce

Screenshot_20210723-171947_FlorisBoard Beta.jpg
20210723_193856.jpg

Environment information

  • FlorisBoard Version: 0.3.13-beta6
  • Install Source: Google PlayStore
  • Device: Samsung Galaxy S9
  • Android: 10
@Glitchy-Tozier Glitchy-Tozier added the bug A bug report label Jul 23, 2021
@patrickgold patrickgold added area: kbd-layout Keyboard layout requests / issues / improvements bug-confirmed A confirmed and reproducible bug report labels Jul 23, 2021
@patrickgold
Copy link
Member

Thanks for your bug report! It seems like I added the dotted-circle so the combining marks aren't weirdly rendered, but at some point the dotted-circle was additionally hard-coded into the labels in the IPA layout. I've fixed the dotted circle appender, so it does not append a dotted circle for the marks if one is already there. Will be available in beta07!

@Glitchy-Tozier
Copy link
Collaborator Author

Glitchy-Tozier commented Jul 24, 2021

Great, good job!

One dotted circle will remain, it's just the un-decorated one that'll be gone, right?

Edit: (Btw, the second layer is even worse)
Screenshot_20210724-080616_GitHub.jpg

@patrickgold
Copy link
Member

One dotted circle will remain, it's just the un-decorated one that'll be gone, right?

Yup, there will always be one dotted circle, else the circumflex marks will be all over the place (the font renderer does not like standalone circumflex marks at all).

@Glitchy-Tozier
Copy link
Collaborator Author

Glitchy-Tozier commented Jul 24, 2021

the font renderer does not like standalone circumflex marks at all

I think adding the circle looks best anyways. (If i only see

, I have no idea whether that's a comma or thát cháráctér.

@patrickgold
Copy link
Member

Yes this is a good point, also adding the dotted circle for these characters is the per se standard across Wikipedia and pretty much all soft keyboards, so I think doing it this way makes most sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kbd-layout Keyboard layout requests / issues / improvements bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants