Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard data logic rework #1091

Merged
merged 3 commits into from Jul 25, 2021
Merged

Keyboard data logic rework #1091

merged 3 commits into from Jul 25, 2021

Conversation

patrickgold
Copy link
Member

@patrickgold patrickgold commented Jul 23, 2021

This PR reworks the KeyData logic so popups can also fully use variation and case selectors. This is required to fully implement the Turkish layout, but also may be needed in the future. This rework also allows for a more general use of the KeyData interface and unifies the text and emoji data base (kinda).

Additionally fixes #1045 and fixes #1089

This allows for selectors to be used within popups as well. Is also the solid foundation for further development with emojis and other keyboards than the text keyboard.
@Glitchy-Tozier
Copy link
Collaborator

I may be wrong, but the dotted-circle-fix seems a bit hacky. Why do you have to check that the circle already exists? Shouldn't the script automatically only add one circle?

@patrickgold
Copy link
Member Author

I may be wrong, but the dotted-circle-fix seems a bit hacky. Why do you have to check that the circle already exists? Shouldn't the script automatically only add one circle?

I wouldn't call it "hacky" per se, just a quick solution to the problem that some layout json files do define the dotted circle for the circumflex marks but others don't. Also if someone in the future adds some circumflex characters, it doesn't matter if dotted circles are included in the json label or not, it will always be rendered correctly.

@Glitchy-Tozier
Copy link
Collaborator

that some layout json files do define the dotted circle for the circumflex marks but others don't.

Ah, in that case it makes perfect sense! :)

@patrickgold patrickgold merged commit 5d12193 into master Jul 25, 2021
@patrickgold patrickgold deleted the keyboard-data-rework branch March 22, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate hints for international phonetic alphabet Turkish only characters: Ğ and her buddy İ
2 participants