Smartbar rework (Milestone v0.4.0 / Module A) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Smartbar XML layout has been completely changed and is now pretty solid. - SmartbarManager's tasks have been split up: UI related things and the management of the state are now managed within the SmartbarView, setting the values and listening to events is now done within TextInputManager. Removing SmartbarManager was an important step because the code and logic was just a pure mess. - SmartbarView is now responsible to manage the state, show and hide features based on various parameters from the keyboard core.
- Number row is now not part of the Smartbar anymore, but is an extension of the character layout, meaning that it is possible to show both a number row and the Smartbar. - The Smartbar can now be disabled in the preferences. - Adjust height calculation when number row is shown. - Fix Smartbar not applying calculated height correctly.
- This allows to have both a debug and release version of FlorisBoard on a single device.
- Smartbar now doesn't show in number, phone and phone2 layouts. - Remove "show instead" preference as it does not do anything anymore. - Change one-handed icon to a smartphone, which should improve clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an important step for providing a good UI and UX for any further features relying on Smartbar, particularly the planned composing suggestions (v0.4.0 / Module B). In detail, this PR adds the following features:
Changes for code contributors:
build.gradleis now configured to apply an application id suffix for debug releases, which allows you to have both a debug and release version installed on the same device, if you are testing out your changes on your personal device (thanks @jeremiah-miller for the idea)