Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time.Time comparison #231

Closed
pierrre opened this issue May 13, 2020 · 2 comments · Fixed by #232
Closed

time.Time comparison #231

pierrre opened this issue May 13, 2020 · 2 comments · Fixed by #232

Comments

@pierrre
Copy link
Contributor

pierrre commented May 13, 2020

Hello !
I plan to add time.Time comparison support.
Is it OK for you ?
@flosch
Copy link
Owner

flosch commented May 13, 2020

Sure, go for it.

@pierrre pierrre mentioned this issue May 14, 2020
Merged
@pierrre
Copy link
Contributor Author

pierrre commented May 17, 2020

I've submitted a PR
#232
Is it the correct way of doing it ?
I'm waiting for your answer before starting to write tests.

flosch pushed a commit that referenced this issue May 18, 2020
@pierrre
add time.Time support to Value and comparison operators (#232)
1bd0148 
Fixes #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add time.Time support to Value and comparison operators
2 participants
@flosch @pierrre