Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null if we aren't showing a selection when calling getSelection. #852

Merged
merged 1 commit into from Nov 25, 2012
Merged

Return null if we aren't showing a selection when calling getSelection. #852

merged 1 commit into from Nov 25, 2012

Conversation

ncb000gt
Copy link
Contributor

@ncb000gt ncb000gt commented Nov 1, 2012

If we've called clearSelection, then calling getSelection shouldn't
return the old selection values. When calling getSelection before a
selection is made, null is returned. It seemed appropriate to do the
same if selection.show was falsy.

Signed-off-by: Nick Campbell nicholas.j.campbell@gmail.com

@ncb000gt
!selection.show => return null from getSelection
54ce0b2 
If we've called `clearSelection`, then calling `getSelection` shouldn't
return the old selection values. When calling `getSelection` before a
selection is made, `null` is returned. It seemed appropriate to do the
same if `selection.show` was falsy.

Signed-off-by: Nick Campbell <nicholas.j.campbell@gmail.com>
@ghost ghost assigned dnschnur Nov 3, 2012
dnschnur added a commit that referenced this pull request Nov 25, 2012
@dnschnur
Merge pull request #852 from ncb000gt/master
e9079c3 
Return null from getSelection if there's no selection.
@dnschnur dnschnur merged commit e9079c3 into flot:master Nov 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dnschnur dnschnur

Labels
None yet
Projects
None yet
Milestone
Release 0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncb000gt @dnschnur