Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null if we aren't showing a selection when calling getSelection. #852

Merged
merged 1 commit into from
Nov 25, 2012
Merged

Return null if we aren't showing a selection when calling getSelection. #852

merged 1 commit into from
Nov 25, 2012

Commits on Nov 1, 2012

  1. !selection.show => return null from getSelection 

    If we've called `clearSelection`, then calling `getSelection` shouldn't
return the old selection values. When calling `getSelection` before a
selection is made, `null` is returned. It seemed appropriate to do the
same if `selection.show` was falsy.

Signed-off-by: Nick Campbell <nicholas.j.campbell@gmail.com>
    @ncb000gt
    ncb000gt committed Nov 1, 2012
    Configuration menu
    Copy the full SHA
    54ce0b2 View commit details
    Browse the repository at this point in the history