add cfn function, checkstyle, cyclic dep #10
Conversation
|
@flou could you take time to this pull request |
brume/config.py
Outdated
| @@ -11,6 +11,33 @@ | |||
| import jinja2 | |||
|
|
|||
|
|
|||
| from stack import stack_outputs | |||
| # current outputs of loaded stacks | |||
| stackOutputsDefinition = {} | |||
There was a problem hiding this comment.
Please use snake_case for variable and methods names.
brume/config.py
Outdated
| click.secho('[ERROR] No key {} variable in stack {}'.format(key, stack_name), err=True, fg='red') | ||
| exit(1) | ||
|
|
||
| def cloudformation(stack_name, key, *subKeys): |
There was a problem hiding this comment.
Please use snake_case for variables in this function.
brume/config.py
Outdated
| @@ -29,6 +56,16 @@ def is_git_repo(): | |||
|
|
|||
| class Config(): | |||
|
|
|||
| @staticmethod | |||
| def cfn(stack_name, key, secondKey=None, thirdKey=None): | |||
There was a problem hiding this comment.
Can you provide a docstring for this method and update the README with an example usage of the cfn function in brume.yaml?
Also please use snake_case for variables in this method.
There was a problem hiding this comment.
i"ve updated all methods with docstring
brume/stack.py
Outdated
| outputs = cfn_client().describe_stacks(StackName=stack)['Stacks'][0].get('Outputs', {}) | ||
| return {o['OutputKey']: o['OutputValue'] for o in outputs} | ||
| description = client.describe_stacks(StackName=stack)['Stacks'][0] | ||
| stackName = description['StackName'] |
There was a problem hiding this comment.
Please use snake_case for variables in this method.
brume/stack.py
Outdated
| @@ -40,17 +40,32 @@ def _make_parameters(params_list): | |||
| return [{'ParameterKey': k, 'ParameterValue': v} for k, v in params_list.items()] | |||
|
|
|||
|
|
|||
| def _outputs_for(stack): | |||
| def _stack_walker(client, outputs, stack, collector): | |||
There was a problem hiding this comment.
Can you provide a docstring for this method?
brume/config.py
Outdated
| stackOutputsDefinition = {} | ||
|
|
||
| def _check_key_exists(key, container, stack_name): | ||
| if not (key in container): |
There was a problem hiding this comment.
You should change this condition to
if key not in container:
brume/config.py
Outdated
|
|
||
| If `subKey` is specified, return the value of the `subKey` found in the value of the `key` in outputs of specified stack `stack_name`. | ||
| """ | ||
| if not (stack_name in stackOutputsDefinition): |
There was a problem hiding this comment.
You should change this condition to
if stack_name not in stackOutputsDefinition:
|
@flou you could see here your requested change, |
|
change are related to #13 |
geronimo-iia
changed the title
|
@flou checkstyle are done on most of code, |
|
@flou anytime to check this PR ? |
used to retrieve cloudformation output value