Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace sumo_binary with render #81

Closed
AboudyKreidieh opened this issue Sep 3, 2018 · 3 comments · Fixed by #136
Closed

replace sumo_binary with render #81

AboudyKreidieh opened this issue Sep 3, 2018 · 3 comments · Fixed by #136
Projects
Issue Triage

Comments

@AboudyKreidieh
Copy link
Member

render is the most common phrase in similar software architectures when specifying whether to use the gui. @eugenevinitsky any thoughts on this? I have something sort of setup, but am hesitant to create a PR if the new change will lead to confusion
@AboudyKreidieh AboudyKreidieh added this to Needs triage in Issue Triage via automation Sep 3, 2018
@AboudyKreidieh AboudyKreidieh moved this from Needs triage to Extremely Easy in Issue Triage Sep 3, 2018
@eugenevinitsky
Copy link
Member

So it'd be render = False or True? Makes a lot of sense to me.

@AboudyKreidieh
Copy link
Member Author

awesome, will create a PR then

@AboudyKreidieh AboudyKreidieh mentioned this issue Sep 8, 2018
Merged
@AboudyKreidieh AboudyKreidieh moved this from Extremely Easy to In Progress in Issue Triage Sep 11, 2018
@eugenevinitsky
Copy link
Member

Done, thanks!

Issue Triage automation moved this from In Progress to Closed Sep 13, 2018
AboudyKreidieh pushed a commit that referenced this issue Mar 7, 2021
@kjang96
Merge pull request #81 from CIRCLES-consortium/transfer_update
b332094 
Cleaned up some transfer related code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Issue Triage
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render flow-project/flow
2 participants
@eugenevinitsky @AboudyKreidieh