Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render #136

Merged
merged 5 commits into from Sep 17, 2018
Merged

Render #136

merged 5 commits into from Sep 17, 2018

Conversation

AboudyKreidieh
Copy link
Member

eugenevinitsky
eugenevinitsky reviewed Sep 13, 2018
View reviewed changes
flow/benchmarks/baselines/grid0.py Outdated
"""Run script for the grid0 baseline.

Parameters
----------
num_runs : int
number of rollouts the performance of the environment is evaluated
over
sumo_binary: str, optional
render : str, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool, not str

eugenevinitsky
eugenevinitsky approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus comment! Thanks for doing this.

@AboudyKreidieh AboudyKreidieh merged commit 165b939 into master Sep 17, 2018
@AboudyKreidieh AboudyKreidieh deleted the render branch September 17, 2018 01:49
crystalzyan pushed a commit to crystalzyan/flow that referenced this pull request Dec 1, 2018
@AboudyKreidieh
Merge pull request flow-project#136 from flow-project/render
a445e75 
Render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugenevinitsky eugenevinitsky eugenevinitsky approved these changes

@cathywu cathywu Awaiting requested review from cathywu

@kanaadp kanaadp Awaiting requested review from kanaadp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace sumo_binary with render
2 participants
@AboudyKreidieh @eugenevinitsky