[react-apollo] Misc. react-apollo improvements

[budde377]

Closes #2175

This enables us to annoate subscribeToMore with the following method

...
import { Query, type QueryRenderProps, type SubscribeToMoreOptions } from 'react-apollo'
 
class DoStuff extends React.Component<{}> {
  _subscribeToMoreOptions: SubscribeToMoreOptions<getThangsQuery, subscribeThangsSubscription> = {
    document: SUBSCRIBE_THANGS,
    updateQuery: (prev, {subscriptionData}) => {
      if (!subscriptionData.data) return prev
      ...
    }
  }

  render () {
    return (
      <Query query={GET_THANGS}>
        {({subscribeToMore, loading, error, data}: QueryRenderProps<getThangsQuery>) => {          
          ...
          subscribeToMore(this._subscribeToMoreOptions)           
          ...
        }}
      </Query>
    )
  }
}
...

similar functionality has been added for fetchMore.

[TLadd]

I'm assuming you're already aware of this, but just to be sure, all of these imports from apollo-client are just resolving to any (both because this import is outside of declare module and because a definition doesn't currently exist).

Started on a PR to add a definition for apollo-client: #2172

[budde377]

I did know that they resolved to any, but I wasn't aware that they had to be in declare module. It'll be interesting to see how much we can reuse when your PR is done!

[TLadd]

FAQ for reference: https://github.com/flowtype/flow-typed/wiki/FAQs#how-do-i-build-type-definitions-that-depend-on-other-definitions.

Appreciate your improvements to the libdef by the way!

[budde377]

Thanks for the link!

[TLadd]

Would it make sense to add defaults for these?

At the moment, I'm extending the Query component and passing in the types, similar to how the apollo typescript docs suggest (https://www.apollographql.com/docs/react/recipes/static-typing.html#typing-components). This change would require going back and adding void, void for each of my Query components.

[budde377]

Actually adding these was a mistake and they aren't used. I chose not to propagate these type variables because their usability is doubtable. The Query component doesn't "care" about those types, and that is also why the QueryRenderProps doesn't have them.

[AndrewSouthpaw]

I'll wait for @TLadd to sign off.

As part of this PR would you mind adding a CONTRIBUTING.md file in the apollo folder and recording any common reviewers? It's helpful to future contributors.

[AndrewSouthpaw]

Waiting on approval.

[budde377]

I've added the CONTRIBUTING.md file with all contributors to the main spec.

[TLadd]

@AndrewSouthpaw Looks good to me

[mlc]

This appears to make flow unhappy:

$ flow status
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ flow-typed/npm/react-apollo_v2.x.x.js:280:68

Cannot use SubscriptionProps [1] with less than 2 type arguments.

 [1] 273│   declare type SubscriptionProps<TData, TVariables> = {
     274│     subscription: DocumentNode,
     275│     variables?: TVariables,
     276│     shouldResubscribe?: boolean | (SubscriptionProps<TData, TVariables>, SubscriptionProps<TData, TVariables>) => boolean,
     277│     children: (result: SubscriptionResult<TData, TVariables>) => React$Node,
     278│   }
     279│
     280│   declare export class Subscription<TData> extends React$Component<SubscriptionProps<TData>> {}
     281│
     282│   declare export type MutationFunction<TVariables> = (options: {
     283│     variables?: TVariables,

[budde377]

@mic, can you check if #2194 fixes it?