[cloudinary_v1.x.x] Add libdefs for cloudinary #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villesau
reviewed
Jan 11, 2019
| | 'imagga_crop' | ||
| | 'imagga_scale'; | ||
|
|
||
| // Source: https://cloudinary.com/documentation/image_transformation_reference |
villesau
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this library has only been partially typed. I did include all the objects that are exported from the top level of this module, but marked them
__TODO__(alias forany). I'm not interested in typing those APIs out completely, as I don't personally use/need those APIs. However, someone who's interested in them can easily update this definition later on.I figured having a partially typed API is better than having no typing at all? This way, coverage can be incrementally improved upon over time. Is this considered a good or bad practice?