Add a lib def for @koa/router #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
force-pushed
the
add-koa-router-libdef
branch
from
1bbe947
to
870cd53
Compare
pascalduez
reviewed
Oct 25, 2019
| @@ -0,0 +1,119 @@ | |||
| type KoaRouter$Middleware = ( | |||
There was a problem hiding this comment.
Any reason to keep those outside of the module definition block?
There was a problem hiding this comment.
No reason really, as I wrote in the description, I mostly copied a previously existing definition and didn't want to redo everything :)
There was a problem hiding this comment.
Please tell me if you'd like that I revisit this to merge it.
There was a problem hiding this comment.
I would personally just declare/export them inside the module scope, without the prefix.
julienw
force-pushed
the
add-koa-router-libdef
branch
from
870cd53
to
4b11688
Compare
pascalduez
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
I copied most of it from
koa-router; indeed this npm module has been forked and renamed because the original was unmaintained.I only kept the version for "v0.104-" but adapted it to make it work with some earlier flow versions, which is simpler if we don't want to support versions of flow earlier than v0.84.
Also I added the newest additions (there's a new parameter in the
urlmethod).Lastly I kept most tests but reorganized them with describe and it, as well as added new ones.
Tell me what you think!