Add a libdef for the mozlog library #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
commented
Oct 25, 2019
|
|
||
| declare type LoggerCreator = (string) => Logger; | ||
|
|
||
| declare export default function mozlog(options: string | {| |
There was a problem hiding this comment.
To be honest I don't know if this is "legit" to use the es module style of exporting if the module itself is using the traditional exports object. I did that here so that the types don't leak outside of the libdef.
There was a problem hiding this comment.
It's fine in most cases, and even preferred.
The commonjs form can make certain types of API difficult if not impossible to model in Flow.
Also there's the argument that Flow users should most likely be using transpilation, so ES modules...
pascalduez
approved these changes
Oct 25, 2019
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
This is a mozilla tool that wraps
intelwith some specifics.