Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpTask URL not encoded when saved #1039

Closed
Heurazio opened this issue May 7, 2018 · 4 comments
Closed

HttpTask URL not encoded when saved #1039

Heurazio opened this issue May 7, 2018 · 4 comments

Comments

@Heurazio
Copy link

Heurazio commented May 7, 2018

Description
When using HTTP Tasks in the modeler, the Request URL is not correctly URL-Encoded when saving the process model.

Problem
This results in errors starting the process (HTTP 500) when there are e.g. not encoded query parameters in the Request URL. This can be found in the logs:

org.flowable.engine.common.api.FlowableException: Invalid URL exception occurred
    ...
    Caused by: java.net.URISyntaxException: Illegal character in query at ...
   ...

Linked Topics
Process won't start with HTTP 500 error
Correct URL Encoding for HTTP Task
@vzickner
Copy link
Contributor

vzickner commented Jun 4, 2018

The problem in the sample you mentioned is that the space character is not valid in URI-objects (the URI is https://example.com/v3/domain/messages?subject=Test 2&text=Test message 2). We should either validate it during modeling or escape the parameters afterwards.
@tijsrademakers @jbarrez which option would you suggest?

@tijsrademakers
Copy link
Contributor

@vzickner I think we should make sure that we escape the parameters. It should be ok to fill-in a value with a space in the modeler.

vzickner added a commit to vzickner/flowable-engine that referenced this issue Jun 4, 2018
@vzickner
Fix encoding of URL before conversion to URI object (flowable#1039).
5bf8ad1
vzickner added a commit to vzickner/flowable-engine that referenced this issue Jun 27, 2018
@vzickner
Improve regex to also handle root as application path (flowable#1039).
3f64b33
jbarrez pushed a commit that referenced this issue Aug 7, 2018
@vzickner @jbarrez
Improve regex to also handle root as application path (#1039).
ac59bb5
jbarrez pushed a commit that referenced this issue Aug 7, 2018
@vzickner @jbarrez
Fix encoding of URL before conversion to URI object (#1039).
22f0d37
@PascalSchumacher
Copy link
Contributor

PascalSchumacher commented Aug 9, 2018 •
edited

I guess this can be closed now that #1101 was merged in 22f0d37?

@Heurazio Heurazio closed this as completed Aug 9, 2018
@Kirinfm
Copy link

Kirinfm commented Jan 29, 2019

Hi @tijsrademakers ,
For Example, we use flowable to grant members permission. GitLab api use https://gitlab.com/api/v4/projects/flowable%2Fflowable-engine/members .
What should I do.

filiphr added a commit to filiphr/flowable-engine that referenced this issue Jun 15, 2020
@filiphr
Make sure that URL encoding works properly for user defined plus char…
1e56c7d 
…acter

Do not use parsing to URL then to URI and instead manually replace space and plus characters with their encoded counterparts.
This also makes sure that users can use encoded ampersand in request parameters
Related to flowable#1039
filiphr added a commit that referenced this issue Jun 15, 2020
@filiphr
Make sure that URL encoding works properly for user defined plus char…
0f84c5b 
…acter

Do not use parsing to URL then to URI and instead manually replace space and plus characters with their encoded counterparts.
This also makes sure that users can use encoded ampersand in request parameters
Related to #1039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tijsrademakers @PascalSchumacher @vzickner @Heurazio @Kirinfm