Remove play-json dependency #55
Conversation
There was a problem hiding this comment.
Code looks good. How does the data look in Rollbar using the default serializer? I recall in the past that there were extra quotes showing up in logged data, which is why I think we tried using Play JSON.
I think you can test locally in sbt console using any project that has Rollbar enabled, as long as you have the ROLLBAR_TOKEN env variable set.
| @@ -140,7 +94,6 @@ object RollbarProvider { | |||
| .sender( | |||
| new SyncSender.Builder() | |||
| .accessToken(token) | |||
| .jsonSerializer(jacksonSerializer) | |||
| .build() | |||
There was a problem hiding this comment.
check to see if we can use the default sender here (i.e. not call it because the defaults are the same)
| val mapper = new ObjectMapper() | ||
|
|
||
| // de/serialize play-json types | ||
| mapper.registerModule(PlayJsonModule) |
There was a problem hiding this comment.
Removing PlayJsonModule this means that we can no longer serialize Js* types (e.g. JsObject). I feel like being able to log objects is important for richer structured log messages. It would be good to determine whether any flow code logs any Js* values
|
Why do we want to remove the play-json dep? Is there a new project with which we want to use lib-log but not play? |
No description provided.