Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular 14 support #91

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add angular 14 support #91

merged 2 commits into from
Jul 20, 2022

Conversation

rternavskyi
Copy link
Contributor

No description provided.

@rternavskyi
Copy link
Contributor Author

@AidasK @evilaliv3 @MartinNuc
Hello, could you please check this PR

@rternavskyi
Copy link
Contributor Author

@AidasK @evilaliv3 @MartinNuc @Coly010 @itsaplev
Hello, could you please check this PR

@AidasK
Copy link
Member

AidasK commented Jul 12, 2022

@MartinNuc can you merge this please?

@MartinNuc
Copy link
Collaborator

MartinNuc commented Jul 14, 2022

@rternavskyi Thank you so much for contribution! I see the pipeline is failing with following error:

> npm run test:ci

Error: projects/ngx-flow/src/lib/flow.directive.ts:134:26 - error TS2314: Generic type 'JQueryStyleEventEmitter<TContext, T>' requires 2 type argument(s).
261
262134       flow as unknown as JQueryStyleEventEmitter,

I will be happy to merge it when it's 🟢

@rternavskyi
Copy link
Contributor Author

@MartinNuc can you merge this please?

@MartinNuc MartinNuc merged commit 50bfcf6 into flowjs:master Jul 20, 2022
@MartinNuc
Copy link
Collaborator

@rternavskyi Could you please try npm run build? 🙏 I tried to run it after merging this PR and it's failing. I am no longer working with Angular therefore I am not sure how to debug it. Can you please take a look? 🙏

@MartinNuc
Copy link
Collaborator

Version 0.6.0 release with support for Angular 14. Thanks @rternavskyi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants