Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Stability and performance improvements #12

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

bwaidelich
Copy link
Collaborator

* Don't share discovery cache over multiple services (#10)
* Don't require options before they are used (#11)
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #12 into master will increase coverage by 5.71%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage      6.75%   12.47%   +5.71%     
- Complexity      175      176       +1     
============================================
  Files             9        9              
  Lines           459      457       -2     
============================================
+ Hits             31       57      +26     
+ Misses          428      400      -28     
Impacted Files Coverage Δ Complexity Δ
Classes/Authentication/OpenIdConnectEntryPoint.php 0.00% <0.00%> (ø) 11.00 <0.00> (ø)
Classes/OpenIdConnectClient.php 25.53% <60.86%> (+25.53%) 40.00 <10.00> (+1.00)
Classes/OAuthClient.php 7.40% <0.00%> (+7.40%) 15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a3ed2...917fc18. Read the comment docs.

@robertlemke robertlemke merged commit ab275fc into master Aug 3, 2020
@robertlemke robertlemke deleted the bugfix/stability-improvements branch August 3, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants